26.3 fb investigate windows failures#2922
Open
labkey-danield wants to merge 22 commits intorelease26.3-SNAPSHOTfrom
Open
26.3 fb investigate windows failures#2922labkey-danield wants to merge 22 commits intorelease26.3-SNAPSHOTfrom
labkey-danield wants to merge 22 commits intorelease26.3-SNAPSHOTfrom
Conversation
Try and wait for folder deltion.
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
Change test to just do a rename and not a delete.
labkey-jeckels
approved these changes
Mar 26, 2026
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Might want to attempt the delete multiple times with delays in-between if it fails since the original failure looks to be caused by Windows locking the file from it still being open by some process. But sounds like this is passing consistently already so feel free to delay that for future troubleshooting, if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The AssayTransformMissingParentDirTest.testMissingParentDirectoryRegression is failing on windows because the expected error message is not shown.
The expected error message is not shown because the directory that contains the R script is not deleted as expected. It looks like windows holds onto the directory a little longer.
This avoids the issue on windows by using a retry mechanism to delete the directory.
Related Pull Requests
Changes